-
Notifications
You must be signed in to change notification settings - Fork 1.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore(anvil
): migrate cheatsmanager to alloy
#6767
Changes from 2 commits
File filter
Filter by extension
Conversations
Jump to
Diff view
Diff view
There are no files selected for viewing
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -1,7 +1,8 @@ | ||
//! Support for "cheat codes" / bypass functions | ||
|
||
use alloy_primitives::Address; | ||
use alloy_rpc_types::Signature; | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. @DaniPopes are we mixing types here? or should we pull signature into primitives? There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. We do have |
||
use anvil_core::eth::transaction::IMPERSONATED_SIGNATURE; | ||
use ethers::types::{Address, Signature}; | ||
use foundry_evm::hashbrown::HashSet; | ||
use parking_lot::RwLock; | ||
use std::sync::Arc; | ||
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
make
self.signature()
return an alloy signature imo, any reason why we cannot port the typed transaction fields to be alloy?There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
thought about doing this, but migrating
typedtransaction
so early would make us migrate most of anvil in one go with a longer running pr—ideally we want to avoid this.TypedTransaction
, along with other base types are getting migrated on this PR: #6778