Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore(
anvil
): migrate cheatsmanager to alloy #6767chore(
anvil
): migrate cheatsmanager to alloy #6767Changes from 1 commit
da78624
482ff02
5ae2fdd
69b6790
File filter
Filter by extension
Conversations
Jump to
There are no files selected for viewing
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
make
self.signature()
return an alloy signature imo, any reason why we cannot port the typed transaction fields to be alloy?There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
thought about doing this, but migrating
typedtransaction
so early would make us migrate most of anvil in one go with a longer running pr—ideally we want to avoid this.TypedTransaction
, along with other base types are getting migrated on this PR: #6778There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@DaniPopes are we mixing types here? or should we pull signature into primitives?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We do have
alloy_primitives::Signature
! we'll pull it in once needed when we get into actually moving types that can recover their signer (TypedTransaction
, e.g) here #6778. For now we can use this type, as right now we just need an equivalence check