Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(foundryup): address shellcheck in installer #7168

Merged
merged 2 commits into from
Feb 19, 2024
Merged

fix(foundryup): address shellcheck in installer #7168

merged 2 commits into from
Feb 19, 2024

Conversation

DaniPopes
Copy link
Member

@DaniPopes DaniPopes commented Feb 19, 2024 •
edited
Loading

Ref #6915

onbjerg
onbjerg approved these changes Feb 19, 2024
View reviewed changes
foundryup/install
curl -# -L $BIN_URL -o $BIN_PATH
chmod +x $BIN_PATH
mkdir -p "$FOUNDRY_BIN_DIR"
curl -sSf -L "$BIN_URL" -o "$BIN_PATH"
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this removes the progress bar

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes, it's a 12KiB file

@DaniPopes DaniPopes merged commit 602cea3 into master Feb 19, 2024
19 checks passed
@DaniPopes DaniPopes deleted the dani/fix-install branch February 19, 2024 12:44
This was referenced Apr 26, 2024
Merged
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@onbjerg onbjerg onbjerg approved these changes

@Evalir Evalir Awaiting requested review from Evalir

@mattsse mattsse Awaiting requested review from mattsse mattsse is a code owner

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@DaniPopes @onbjerg