fix(forge): do not error when artifact does not have an abi #7184
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
DaniPopes
approved these changes
Feb 19, 2024
klkvr
added a commit
to klkvr/foundry
that referenced
this pull request
Feb 20, 2024
…rs#7184) * fix(forge): do not error when artifact does not have an abi * unused import
This was referenced Apr 26, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
Closes #7182
Previous linker impl filtered out artifacts without abi during linking
foundry/crates/forge/src/link.rs
Line 182 in 7116e24
Solution
I don't known in which cases solc emits artifacts without an abi, would be nice to get a repro and add a test case for this