fix(forge): total duration is not the sum of individual runs #7228
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mattsse
approved these changes
Feb 24, 2024
DaniPopes
force-pushed
the
dani/fix-test-duration
branch
from
fb4704b
to
f90ed3a
Compare
zeroXbrock
pushed a commit
to flashbots/suavex-foundry
that referenced
this pull request
Apr 2, 2024
…-rs#7228) * fix(forge): total duration is not the sum of individual runs * updates * update * chore: clippy
This was referenced Apr 26, 2024
3esmit
added a commit
to vacp2p/foundry-template
that referenced
this pull request
Aug 31, 2024
Foundry changed the test command output, changing the "Test result" to "Suite result", causing the command gas-report to stop working. See foundry-rs/foundry#7228 foundry-rs/foundry@17215eb Updating the word on the gas-report command fixes the problem.
3 tasks
|
Any reason for changing the wording of "Test result" to "Suite result"? Please, avoid changing this stuff without any reason, because it might break automated tools. See vacp2p/foundry-template#31 |
|
Because it's more correct, please don't rely on an unspecified textual output :^) |
0x-r4bbit
pushed a commit
to vacp2p/foundry-template
that referenced
this pull request
Sep 13, 2024
Foundry changed the test command output, changing the "Test result" to "Suite result", causing the command gas-report to stop working. See foundry-rs/foundry#7228 foundry-rs/foundry@17215eb Updating the word on the gas-report command fixes the problem.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Since both individual suites (contracts) and tests can run in parallel, the sum of their individual durations can be different from the actual wall clock time taken executing them