Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(forge): blobbasefee cheatcode #7598

Merged
merged 6 commits into from
Apr 10, 2024
Merged

Conversation

kamuik16
Copy link
Contributor

@kamuik16 kamuik16 commented Apr 8, 2024

Closes #7002

Copy link
Member

@Evalir Evalir left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks! needs forge fmt + nit. tests need to be run using the cancun test profile

crates/cheatcodes/spec/src/vm.rs Show resolved Hide resolved
@kamuik16
Copy link
Contributor Author

kamuik16 commented Apr 8, 2024

Thanks! needs forge fmt + nit. tests need to be run using the cancun test profile

ran the test with cancun evm version but did not push into the pr.

@kamuik16 kamuik16 requested a review from Evalir April 8, 2024 13:51
@yash-atreya
Copy link
Member

Hey @kamuik16, let me know if you need help with anything

@kamuik16
Copy link
Contributor Author

kamuik16 commented Apr 9, 2024

Hey @kamuik16, let me know if you need help with anything

I am waiting for reviews. I think it's done from my side. Working correctly.

Copy link
Member

@mattsse mattsse left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

Copy link
Member

@mattsse mattsse left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ah this is now a cheat that only works with CANCUN, hence the failing test.

so what we need now is a test, just like:

https://github.com/foundry-rs/foundry/blob/master/crates/forge/tests/it/cheats.rs#L10-L26

but uses

https://github.com/foundry-rs/foundry/blob/master/crates/forge/tests/it/test_helpers.rs#L273-L275

and we need a cancun/cheats folder not default/cheats

TODO

  • create cancun/cheats folder and move test
  • add a new rust test similar to cheats that uses the TEST_DATA_CANCUN config

@kamuik16
Copy link
Contributor Author

hey @mattsse! I moved the test into cancun folder and ci is passing but struggling with the test.

@kamuik16 kamuik16 requested a review from mattsse April 10, 2024 09:26
Copy link
Member

@mattsse mattsse left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@mattsse mattsse merged commit f0ea57a into foundry-rs:master Apr 10, 2024
19 checks passed
@kamuik16 kamuik16 deleted the kamuik16/7002 branch April 10, 2024 11:18
@kamuik16
Copy link
Contributor Author

lgtm

thanks for the test help!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add cheatcode to set block.blobbasefee
4 participants