fix: use 2718 encoding for transactions trie root calculation #7718
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mattsse
approved these changes
Apr 18, 2024
|
yeah I think those should be public, because they are required for things like this, similar to |
klkvr
added a commit
that referenced
this pull request
Apr 20, 2024
* fix: use 2718 encoding for tx root * fmt * rm doc * fix
This was referenced Apr 26, 2024
2 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
Closes #7698
Solution
Implement
Encodable2718forTypedTransactionand use correct encoding for transactions root calculation.alloy does not expose methods for encoding transaction types other than
TxEnvelope::encode_2718, so currently this impl clones txs to constructTxEnvelope. We should probably exposeencode_with_signaturemethods used here to avoid this