fix: correctly process relative paths as --skip values
#7737
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mattsse
approved these changes
Apr 20, 2024
crates/common/src/compile.rs
Outdated
Comment on lines
576
to
580
| } else if let Ok(stripped) = file.strip_prefix(&self.project_root) { | ||
| is_match_exclude(matcher, stripped) | ||
| } else { | ||
| true | ||
| } |
There was a problem hiding this comment.
style nit: I believe we can do
file.strip_prefix(&self.project_root).map_or(true, |stripped| is_match_exclude(matcher, stripped))
This was referenced Apr 26, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
Closes #7730
Solution
keep root path and try matching stripped path as well