feat(forge): add `compiler` subcommand #7909

jpgonzalezra · 2024-05-11T22:22:22Z

Closes: #7656

Motivation

The "issue 7654" it is proposed to add a new command, forge detect-solc (in this PR "forge solc vr" or "forge solc version-resolving"), which returns the detected version of the Solidity compiler based on the project configuration. This command aims to help users identify compatible versions of the Solidity compiler for different folders in large projects by providing insights into the version resolution algorithm used.

Solution

Added a solc command with the subcommand version-resolving, which retrieves the resolved versions of the Solidity compiler (solc) within the project using the SolcVersionManager from the foundry_compilers library.

Ex. with solmate project

$ forge solc vr

mattsse

this seems fine,

wdyt @klkvr

klkvr

looks good to me

mds1 · 2024-05-13T13:07:46Z

Support for the --skip flag that forge build has would be really nice to allow filtering out directories from the results. When I test this, the output is dominated by e.g. lib/ and test/ files that obscure the src/ files of interest (not a blocker for this PR, can be done in a follow up)

jpgonzalezra · 2024-05-13T13:34:35Z

Thanks for the comments, I can add support for the --skip flag in this PR or another one.
And maybe we can add --silent to only print the version, something link:

one version:

0.8.15

More than one:

0.8.15
0.8.25

What do you think guys?

zerosnacks · 2024-07-15T12:11:34Z

Hi @jpgonzalezra thanks for the PR! Would be great to get this ready to be merged

I support adding the --skip flag to this PR. Perhaps rather than --silent it makes sense to add different levels of verbosity for the logs that are emitted where the lowest level yields:

0.8.15
0.8.25

And higher levels of verbosity as proposed by you:

- 0.8.15
  - <path>
  - <path>
  - <path>

- 0.8.25
  - <path>
  - <path>
  - <path>

jpgonzalezra · 2024-07-15T13:31:56Z

@zerosnacks Awesome, I'll fix the conflicts so we can merge. If we want to add anything else, I'll do it in a separate PR. What do you think?

zerosnacks · 2024-07-15T13:43:16Z

@zerosnacks Awesome, I'll fix the conflicts so we can merge. If we want to add anything else, I'll do it in a separate PR. What do you think?

Great, we can do this as follow ups - not a blocker for me for this PR

jpgonzalezra · 2024-07-15T15:17:21Z

@zerosnacks I need to make some changes to the PR because there have been significant updates in the compilers repository. See this commit: foundry-rs/compilers@c78e2ea. I believe I need to use the "detect_version" function. I'll work on that. 💪

zerosnacks · 2024-07-31T11:42:06Z

Thanks @jpgonzalezra! Let me know if you run into any problems

yash-atreya · 2024-09-12T07:43:21Z

@jpgonzalezra friendly bump here. Do you still have the bandwidth to complete this?

zerosnacks · 2024-09-12T12:26:31Z

Would it make sense to generalize this to forge compiler --list?

grandizzy

@zerosnacks could we add a basic test for it?

zerosnacks · 2024-10-14T13:47:10Z

Pending next release of https://github.com/foundry-rs/compilers as it required minor changes upstream to test multi-compiler mode, specifically Vyper.

Command name updated to forge compiler resolve

Updated PR with compiler updates, added JSON compatibility, added verbose / non-verbose mode and added skip flag.

Apart from this blocker, ready for review

crates/forge/bin/cmd/compiler.rs

.github/workflows/nextest.yml

crates/forge/bin/cmd/compiler.rs

Co-authored-by: DaniPopes <57450786+DaniPopes@users.noreply.github.com>

…n installs

crates/forge/tests/cli/compiler.rs

zerosnacks · 2024-10-16T11:25:42Z

cc @grandizzy would you mind doing a final review before merging?

grandizzy

LGTM!

wonder if it would be useful to add evm version too at some point, smth like

DaniPopes · 2024-10-16T12:44:23Z

Like the max supported version by compiler?

zerosnacks · 2024-10-16T12:46:55Z

wonder if it would be useful to add evm version too at some point

like the max supported version by compiler?

Added a follow-up ticket here: #9125

* feat(forge): add solc subcommand and utilities * style: improve formatting in solc.rs file * fix: merge * add json compatible output * add basic tests * add basic tests * clean up * finish tests * add skip flag * add vyper for unit tests * move tests, pin compiler version, use forgetest! * update CI test location for target Python / Vyper * update foundry-compilers crate * Update crates/forge/bin/cmd/compiler.rs Co-authored-by: DaniPopes <57450786+DaniPopes@users.noreply.github.com> * `compiler` command is sync, remove conditions on CI for Vyper / Python installs * is_jsonlines -> is_json --------- Co-authored-by: zerosnacks <zerosnacks@protonmail.com> Co-authored-by: zerosnacks <95942363+zerosnacks@users.noreply.github.com> Co-authored-by: DaniPopes <57450786+DaniPopes@users.noreply.github.com>

feat(forge): add solc subcommand and utilities

eacb549

jpgonzalezra requested review from DaniPopes, Evalir and mattsse as code owners May 11, 2024 22:22

style: improve formatting in solc.rs file

09bb812

mattsse reviewed May 12, 2024

View reviewed changes

klkvr approved these changes May 12, 2024

View reviewed changes

jpgonzalezra added 2 commits July 15, 2024 10:49

chore: sync branch with master

76e4c33

fix: merge

db2864b

zerosnacks added this to the v1.0.0 milestone Jul 31, 2024

zerosnacks added the C-forge Command: forge label Jul 31, 2024

zerosnacks mentioned this pull request Jul 31, 2024

feat: add path to compiler to forge compiler resolve #5429

Open

zerosnacks self-assigned this Oct 10, 2024

zerosnacks changed the title ~~feat(forge): add solc subcommand and utilities~~ feat(forge): add solc subcommand and utilities (forge compiler --list) Oct 10, 2024

merge in master, fix resolving

bd69e92

zerosnacks requested review from grandizzy, yash-atreya and zerosnacks as code owners October 14, 2024 09:00

grandizzy reviewed Oct 14, 2024

View reviewed changes

zerosnacks added 2 commits October 14, 2024 11:44

add json compatible output

433c0fb

add basic tests

abe2456

zerosnacks added the T-blocked Type: blocked label Oct 14, 2024

DaniPopes requested changes Oct 14, 2024

View reviewed changes

crates/forge/bin/cmd/compiler.rs Outdated Show resolved Hide resolved

zerosnacks added 2 commits October 14, 2024 16:46

move tests, pin compiler version, use forgetest!

f84cabb

update CI test location for target Python / Vyper

2d1de84

zerosnacks force-pushed the 7656 branch from d1164e8 to 2d1de84 Compare October 14, 2024 16:09

zerosnacks requested review from DaniPopes, grandizzy and mattsse October 15, 2024 07:50

zerosnacks added 2 commits October 15, 2024 16:24

Merge remote-tracking branch 'upstream/master' into 7656

642752f

update foundry-compilers crate

608214f

DaniPopes changed the title ~~feat(forge): add solc subcommand and utilities (forge compiler --list)~~ feat(forge): add compiler subcommand Oct 16, 2024

DaniPopes requested changes Oct 16, 2024

View reviewed changes

.github/workflows/nextest.yml Outdated Show resolved Hide resolved

crates/forge/bin/cmd/compiler.rs Outdated Show resolved Hide resolved

crates/forge/bin/cmd/compiler.rs Outdated Show resolved Hide resolved

zerosnacks and others added 3 commits October 16, 2024 11:51

Update crates/forge/bin/cmd/compiler.rs

65d8d0b

Co-authored-by: DaniPopes <57450786+DaniPopes@users.noreply.github.com>

compiler command is sync, remove conditions on CI for Vyper / Pytho…

4b5a08f

…n installs

Merge remote-tracking branch 'upstream/master' into 7656

b606311

DaniPopes approved these changes Oct 16, 2024

View reviewed changes

crates/forge/tests/cli/compiler.rs Outdated Show resolved Hide resolved

crates/forge/tests/cli/compiler.rs Outdated Show resolved Hide resolved

is_jsonlines -> is_json

65a1b2d

zerosnacks reviewed Oct 16, 2024

View reviewed changes

crates/forge/tests/cli/compiler.rs Outdated Show resolved Hide resolved

grandizzy approved these changes Oct 16, 2024

View reviewed changes

zerosnacks mentioned this pull request Oct 16, 2024

feat(forge compiler): add EVM version alongside version output #9125

Closed

zerosnacks merged commit adb6aba into foundry-rs:master Oct 16, 2024
22 checks passed

zerosnacks removed the T-blocked Type: blocked label Oct 16, 2024

This was referenced Nov 5, 2024

chore: resolve merge conflicts for upstream-57bb12e matter-labs/foundry-zksync#693

Merged

chore: sync with upstream 57bb12e matter-labs/foundry-zksync#698

Merged

grandizzy added the T-feature Type: feature label Dec 18, 2024

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

feat(forge): add `compiler` subcommand #7909

feat(forge): add `compiler` subcommand #7909

jpgonzalezra commented May 11, 2024 •

edited by zerosnacks

Loading

mattsse left a comment

klkvr left a comment

mds1 commented May 13, 2024

jpgonzalezra commented May 13, 2024 •

edited

Loading

zerosnacks commented Jul 15, 2024 •

edited

Loading

jpgonzalezra commented Jul 15, 2024

zerosnacks commented Jul 15, 2024

jpgonzalezra commented Jul 15, 2024

zerosnacks commented Jul 31, 2024

yash-atreya commented Sep 12, 2024

zerosnacks commented Sep 12, 2024

grandizzy left a comment

zerosnacks commented Oct 14, 2024 •

edited

Loading

zerosnacks commented Oct 16, 2024

grandizzy left a comment

DaniPopes commented Oct 16, 2024

zerosnacks commented Oct 16, 2024 •

edited

Loading

feat(forge): add compiler subcommand #7909

feat(forge): add compiler subcommand #7909

Conversation

jpgonzalezra commented May 11, 2024 • edited by zerosnacks Loading

Motivation

Solution

mattsse left a comment

Choose a reason for hiding this comment

klkvr left a comment

Choose a reason for hiding this comment

mds1 commented May 13, 2024

jpgonzalezra commented May 13, 2024 • edited Loading

zerosnacks commented Jul 15, 2024 • edited Loading

jpgonzalezra commented Jul 15, 2024

zerosnacks commented Jul 15, 2024

jpgonzalezra commented Jul 15, 2024

zerosnacks commented Jul 31, 2024

yash-atreya commented Sep 12, 2024

zerosnacks commented Sep 12, 2024

grandizzy left a comment

Choose a reason for hiding this comment

zerosnacks commented Oct 14, 2024 • edited Loading

zerosnacks commented Oct 16, 2024

grandizzy left a comment

Choose a reason for hiding this comment

DaniPopes commented Oct 16, 2024

zerosnacks commented Oct 16, 2024 • edited Loading

feat(forge): add `compiler` subcommand #7909

feat(forge): add `compiler` subcommand #7909

jpgonzalezra commented May 11, 2024 •

edited by zerosnacks

Loading

jpgonzalezra commented May 13, 2024 •

edited

Loading

zerosnacks commented Jul 15, 2024 •

edited

Loading

zerosnacks commented Oct 14, 2024 •

edited

Loading

zerosnacks commented Oct 16, 2024 •

edited

Loading