-
Notifications
You must be signed in to change notification settings - Fork 1.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: implement EOF methods in Inspector trait #8123
feat: implement EOF methods in Inspector trait #8123
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
okay, I think I understood this.
with EOF we have an additional create hook.
with the new enums we can unify our handlers for both input/output pairs
I think this makes sense and is the best solution
b76da2e
to
3d291df
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
this approach lgtm, only have a suggestion re mod layout
wdyt @DaniPopes
Since there hasn't been a revm release yet, I would like to fix this upstream. |
ok then what is missing in this PR, how can we move it forward? or should we close it? @DaniPopes @mattsse @rakita |
We're waiting on a revm release that includes working EOF |
7ccb6d2
to
1a7a026
Compare
ok, updated for latest changes in revm, ptal @DaniPopes @mattsse @rakita |
1a7a026
to
07f873c
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm
Motivation
The
Inspector
trait in revm includes now theeofcreate
andeofcreate_end
methods with default implementations, we need to add custom implementations for each type implementing the traitSolution
The implementations aim to have the same behaviour as the existing
create
andcreate_end
methods.