fix: update bytecode matching for coverage #8214
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
ref #6875 (comment)
Solution
Update
find_by_{deployed,creation}_code
to not exit after first diff_score < 0.1, but instead try matching until the minimal diff score is found.cc @grandizzy this fixes the issue for https://github.com/grandizzy/forge-coverage-bug/tree/master though not sure about other repos