feat(forge): option to replay last test run failures only #8338
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
grandizzy
changed the title
zerosnacks
reviewed
Jul 3, 2024
zerosnacks
reviewed
Jul 3, 2024
crates/forge/bin/cmd/test/mod.rs
Outdated
| /// Re-run recorded test failures from last run. | ||
| /// If no failure recorded then regular test run is performed. | ||
| #[arg(long)] | ||
| pub run_failures: bool, |
There was a problem hiding this comment.
Could possibly be shortened to --rerun for brevity as people will likely append it to the command after running their initial test that failed
There was a problem hiding this comment.
yep, can change. Not sure though it would be obvious that only failures are run if renamed to --rerun?
There was a problem hiding this comment.
changed it in 55f68c9 description should be enough to make it clear it reruns only failures 👍
Small change in the way test match is extracted
DaniPopes
approved these changes
Jul 3, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
Closes #4000
Solution
--rerunin filter args to run only test failures from last runcache/test-failuresfile. File path can be configured in tomltest_failures_file = path/to/fileand is removed onforge clean--show-progressin test args