feat: support mesc #8760
Merged
feat: support mesc #8760
+35
−4
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
onbjerg
added
T-feature
klkvr
approved these changes
Aug 29, 2024
DaniPopes
reviewed
Sep 2, 2024
| return Some(endpoint.map(Cow::Owned)) | ||
| } | ||
|
|
||
| if let Ok(Some(endpoint)) = mesc::get_endpoint_by_query(maybe_alias, Some("foundry")) { |
There was a problem hiding this comment.
there are errors in there related to eg mesc not being enabled and such, which is why i chose to ignore it. don't want it to fail for people not using mesc
7 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
mesc is a cross-tool endpoint management tool that allows users to manage endpoints across chains, set defaults, and aliases.
We already have some pre-existing ways to do this in Foundry (i.e. rpc aliases in
foundry.toml), but supporting mesc makes sense going forward. I'd also recommend that we consider deprecating the endpoint management stuff we have currently at some point in the future.Solution
Before looking at rpc aliases in
foundry.toml, we query mesc first. mesc can handle things like the chain name, chain ID, a raw url, aliases and more.This PR does not change the default foundry url based on mesc as I felt that might be too big of a change, given setting an RPC url in some contexts ends up enabling forking or other behavior
Closes #8502