-
Notifications
You must be signed in to change notification settings - Fork 1.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(cheatcodes): add vm.assumeNoRevert for fuzz tests #8780
Conversation
should this only re-run if next call reverts? went through issues and seems like this is the common usecase, current version might result in footguns, especially given that sometimes it's hard to craft an array with addresses whitelist |
I think this makes sense, was looking at #7246 (comment) comment and thought we may want to provide same behavior as when setting |
8a6a659
to
16eca7b
Compare
Spec sgtm, and do we also increment the rejects counter the same way? A single test rejects counter for this + |
yep, the rejects counter is incremented same way and shared by both assumes |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm, pending @klkvr
Motivation
Closes #4090
Closes #7246
Similar with
assume
cheatcode, but for discarding inputs in fuzz runs that reverts:Solution