feat: add support for test skip reasons #8858
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
DaniPopes
commented
Sep 12, 2024
| } | ||
| s.push(']'); | ||
| s.yellow().fmt(f) | ||
| } | ||
| TestStatus::Failure => { |
There was a problem hiding this comment.
only functional change here is removing the unconditional . Reason: and "assertion failed" placeholder
klkvr
approved these changes
Sep 12, 2024
mattsse
approved these changes
Sep 12, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds
vm.skip(bool,string)for an optional string reason which shows up in the output.Unfortunately not super straight forward for fuzz tests because we have to decode the encoded reason again to properly propagate it
+ tweaks to a few error messages and cleanups
Can be added to #8852