feat(cheatcodes): add delegatecall to pranking
#8863
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
EdwardJES
commented
Sep 13, 2024
crates/cheatcodes/src/inspector.rs
Outdated
| @@ -833,6 +833,19 @@ impl Cheatcodes { | |||
|
|
|||
| // Apply our prank | |||
| if let Some(prank) = &self.prank { | |||
| // Apply delegate call. call.caller will not equal prank.prank_caller | |||
There was a problem hiding this comment.
Hey @zerosnacks, my understanding is a little fuzzy here. It seems in the case of a delegate call that call.caller == prank.prank_caller will not be true. Is it suitable to have this here? Ty.
There was a problem hiding this comment.
cc @DaniPopes would you have more context on this?
EdwardJES
force-pushed
the
edwardjes/delegatecall
branch
from
a7e8123
to
325c218
Compare
EdwardJES
force-pushed
the
edwardjes/delegatecall
branch
from
8a65994
to
d964aad
Compare
2 tasks
EdwardJES
changed the title
cheatcodes): add delegatecall to prankingcheatcodes): add delegatecall to pranking
|
Hi @EdwardJES thanks for your PR - my apologies that it has taken a while to respond |
EdwardJES
requested review from
DaniPopes,
klkvr,
mattsse,
grandizzy and
yash-atreya
as code owners
EdwardJES
changed the title
cheatcodes): add delegatecall to prankingcheatcodes): add delegatecall to pranking
|
gentle bump on this @zerosnacks, @DaniPopes . Thank you 🙏 |
|
@EdwardJES is there anything waiting from us to unblock the PR or can we start the review? thank you! |
|
@grandizzy all good to go, thanks! |
grandizzy
force-pushed
the
edwardjes/delegatecall
branch
from
bac569b
to
3632509
Compare
grandizzy
reviewed
Nov 15, 2024
|
@grandizzy, thank you for the review and help in rebasing. Added your suggestion 🙏. |
grandizzy
approved these changes
Nov 15, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
Closes #824. Currently there is no easy way to test delegate calls using foundry tests.
Solution
delegate_callflag to the prank.