chore: rename snapshot to be more specific
#8945
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
zerosnacks
changed the title
snapshot to be more specific
zerosnacks
requested review from
DaniPopes,
klkvr and
mattsse
as code owners
zerosnacks
added a commit
that referenced
this pull request
Sep 24, 2024
This was referenced Sep 24, 2024
grandizzy
approved these changes
Sep 25, 2024
mattsse
approved these changes
Sep 25, 2024
There was a problem hiding this comment.
all of these seem fine,
the deprecation notice is great and this doesn't break afaict, but ptal @DaniPopes
Comment on lines
+513
to
+515
| /// `snapshot` is being deprecated in favor of `snapshotState`. It will be removed in future versions. | ||
| #[cheatcode(group = Evm, safety = Unsafe, status = Deprecated(Some("replaced by `snapshotState`")))] | ||
| function snapshot() external returns (uint256 snapshotId); |
|
cc @DaniPopes would be great to get this reviewed / merged if you find time for it, thanks! |
|
Sorry, forgot, LGMT |
|
Can someone please update |
pcaversaccio
added a commit
to pcaversaccio/createx
that referenced
this pull request
Oct 3, 2024
### 🕓 Changelog The Foundry PR [#8945](foundry-rs/foundry#8945) introduced a renaming of the `snapshot` and `revertTo` cheat codes to `snapshotState` and `revertToState`, respectively. This PR aligns our test suite with the newly revised cheat codes. --------- Signed-off-by: Pascal Marco Caversaccio <pascal.caversaccio@hotmail.ch>
pcaversaccio
added a commit
to pcaversaccio/snekmate
that referenced
this pull request
Oct 3, 2024
### 🕓 Changelog The Foundry PR [#8945](foundry-rs/foundry#8945) introduced a renaming of the `snapshot` and `revertTo` cheat codes, now referred to as `snapshotState` and `revertToState`. In response, this PR updates our test suite—specifically the `ERC721Test` contract—to align with these revised cheat codes. Additionally, `ethers` has been upgraded to the latest version [`6.13.3`](https://github.com/ethers-io/ethers.js/releases/tag/v6.13.3), and all submodules have been updated to their most recent available commits. --------- Signed-off-by: Pascal Marco Caversaccio <pascal.caversaccio@hotmail.ch>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
Goal is to clarify the difference between
forge snapshot,state snapshotsandgas snapshotsas we re-use the terminology. This is in preparation for #8952.Splits out the snapshot renaming incl. cheatcode deprecation (with shared implementation) originally part of #8755 as there was consensus on this proposed change and it de-clutters the PR making it easier to review.
The new
gas snapshotPR can be found here: #8952 and branches off of here.Related:
Solution
Should include no user-facing breaking changes, yields deprecation warning as added here: #8883