Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: disable optimizations when --decode-internal is set #8989

Closed

Conversation

zerosnacks
Copy link
Member

@zerosnacks zerosnacks commented Sep 30, 2024

Motivation

Closes: #8986
Closes: #8840, added warning that optimizations are disabled to both coverage and test

Solution

Automatically disables optimization settings when running with the --decode-internal flag (incl. flamecharts / flamegraphs), with same settings used by forge coverage

Now emits a warning that the optimizer is disabled

When using --via-ir it switches to use the --ir-minimum flag, also emitting a warning

cc @klkvr

@klkvr
Copy link
Member

klkvr commented Sep 30, 2024

#8986 looks like a source map parsing issue? disabling optimizer on --decode-internal will cause recompilation and might result in stack too deep errors, this makes flag less user-friendly

we should start with fixing source map parser to not throw this error

@zerosnacks zerosnacks added the T-blocked Type: blocked label Sep 30, 2024
@zerosnacks zerosnacks self-assigned this Sep 30, 2024
@zerosnacks
Copy link
Member Author

Disabling optimizer on --decode-internal will cause recompilation and might result in stack too deep errors, this makes flag less user-friendly

Good point

Closing in favor of investigating #8986 (comment) more deeply and tackle this at the root

@zerosnacks zerosnacks closed this Oct 2, 2024
@zerosnacks zerosnacks removed the T-blocked Type: blocked label Oct 2, 2024
@zerosnacks zerosnacks deleted the zerosnacks/disable-optimization-with-decode-internal branch October 4, 2024 07:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: Completed
2 participants