fix: disable optimizations when --decode-internal
is set
#8989
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
Closes: #8986
Closes: #8840, added warning that optimizations are disabled to both
coverage
andtest
Solution
Automatically disables optimization settings when running with the
--decode-internal
flag (incl. flamecharts / flamegraphs), with same settings used byforge coverage
Now emits a warning that the optimizer is disabled
When using
--via-ir
it switches to use the--ir-minimum
flag, also emitting a warningcc @klkvr