feat(cast): add --rpc-timeout option
#9044
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
PanGan21
requested review from
DaniPopes,
klkvr,
mattsse,
grandizzy,
yash-atreya and
zerosnacks
as code owners
PanGan21
changed the title
--timeout option
DaniPopes
requested changes
Oct 7, 2024
PanGan21
changed the title
--timeout option--rpc-timeout option
grandizzy
reviewed
Oct 23, 2024
grandizzy
approved these changes
Oct 24, 2024
There was a problem hiding this comment.
lgtm, thank you! @zerosnacks @yash-atreya could you please check it too before merging?
zerosnacks
reviewed
Oct 24, 2024
zerosnacks
reviewed
Oct 24, 2024
Minor documentation nits
zerosnacks
approved these changes
Oct 24, 2024
There was a problem hiding this comment.
Thanks @PanGan21 for your PR! Applied some minor documentation fixes. LGTM!
DaniPopes
approved these changes
Oct 24, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
Context: #8959
Solution
The following pr adds
--rpc-timeoutoption to cast command overriding the default rpc timeout.