Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Support cast run quorum private txn #9058

Open
wants to merge 6 commits into
base: master
Choose a base branch
from
Open

Support cast run quorum private txn #9058

Changes from 4 commits
Commits
Show all changes
6 commits
Select commit Hold shift + click to select a range
0dc8b87
feat: support quorum private transaction during cast run
rodionlim Oct 3, 2024
581c3af
feat: rust error handling
andyrobert3 Oct 7, 2024
41ba49f
Refactor cast private txn checks + error handling
andyrobert3 Oct 7, 2024
5e30117
feat: error on quorum calls should revert to default behaviour instea…
rodionlim Oct 8, 2024
56ef7cb
feat: refactor configuring for quorum transaction to a separate function
rodionlim Oct 12, 2024
caa166a
Merge branch 'master' into support_cast_run_quorum_private_txn
rodionlim Oct 16, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
39 changes: 35 additions & 4 deletions crates/cast/bin/cmd/run.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,6 +1,7 @@
use alloy_primitives::U256;
use alloy_primitives::{Bytes, Uint, U256};
use alloy_provider::Provider;
use alloy_rpc_types::BlockTransactions;
use alloy_transport::TransportResult;
use cast::{revm::primitives::EnvWithHandlerCfg, traces::TraceKind};
use clap::Parser;
use eyre::{Result, WrapErr};
Expand Down Expand Up @@ -109,7 +110,7 @@ impl RunArgs {
.build()?;

let tx_hash = self.tx_hash.parse().wrap_err("invalid tx hash")?;
let tx = provider
let mut tx = provider
.get_transaction_by_hash(tx_hash)
.await
.wrap_err_with(|| format!("tx not found: {tx_hash:?}"))?
Expand Down Expand Up @@ -188,10 +189,10 @@ impl RunArgs {
tx.transaction_type == Some(SYSTEM_TRANSACTION_TYPE)
{
pb.set_position((index + 1) as u64);
continue;
continue
}
if tx.hash == tx_hash {
break;
break
}

configure_tx_env(&mut env, &tx.inner);
Expand Down Expand Up @@ -231,6 +232,36 @@ impl RunArgs {
let result = {
executor.set_trace_printer(self.trace_printer);

if let Some(signature) = tx.inner.signature {
let v = signature.v;
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

not opposed to this, but I'd like to have this ideally as a separate function so we can properly document this and have this isolated.

this should probably also check the chainid?

Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi @mattsse

We agree on the first point to create a separate function, will update the PR

On the chainId topic:

Quorum explicitly doesn't allow a chainId of 1, it will not run if it is configured this way
https://docs.goquorum.consensys.io/concepts/network-and-chain-id

Are you saying that if chainId is 1, then is_private_quorum_txn should be false here?

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@mattsse, I refactored this out into a separate function, not sure if you want it isolated via a CLI flag as well


// 37/38 for private quorum transactions, tessera hash is 64 bytes
let is_private_quorum_txn =
(v == Uint::from(37) || v == Uint::from(38)) && tx.input.len() == 64;

if is_private_quorum_txn {
println!("Private quorum transaction detected.");

let result: TransportResult<Bytes> = provider
.client()
.request("eth_getQuorumPayload", (tx.input.clone(),))
.await;

match result {
Ok(tessera_input) => {
println!(
"Executing private quorum transaction with quorum payload: {:?}",
tessera_input.to_string()
);
tx.input = tessera_input;
}
Err(e) => {
println!("eth_getQuorumPayload threw an error: {e}, cannot fetch transaction input {:?}", tx.hash);
}
}
}
}

configure_tx_env(&mut env, &tx.inner);

if let Some(to) = tx.to {
Expand Down