-
Notifications
You must be signed in to change notification settings - Fork 1.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(config
): set default evm version to cancun
#9131
Conversation
Related: #8614 |
41ed902
to
8e8f311
Compare
ab270ce
to
cdda83c
Compare
forge
): set default evm version to cancun
forge
): set default evm version to cancunconfig
): set default evm version to cancun
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Supportive of moving to Cancun as default now, some minor notes / questions in regards to changes
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Lgtm 👍
I think going forward the test structure and such updates could be simplified a lot with #8564 that is allowing inline evm config version. |
pending review cc @yash-atreya / @klkvr |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm
Motivation
Closes #8614
Closes #7014 : with updated version we can proper normalize versions post paris
Related tests
foundry/crates/forge/tests/cli/config.rs
Lines 761 to 769 in 0acbb72
Closes #5513 : with updated cancun version, warm coinbase(EIP-3651) is set by default
Solution