Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore: format chained error for EvmError #9169

Merged
merged 1 commit into from
Oct 23, 2024
Merged

chore: format chained error for EvmError #9169

merged 1 commit into from
Oct 23, 2024

Conversation

grandizzy
Copy link
Collaborator

Motivation

in #9161 message presented to user was

Error:
Failed to deploy script:
backend: failed while inspecting

then foundry code was looked up to figure out it was failing with Header(PrevrandaoNotSet)

Solution

  • chain EvmError messages, add test

@grandizzy grandizzy marked this pull request as ready for review October 23, 2024 09:55
@grandizzy grandizzy merged commit 9252e98 into foundry-rs:master Oct 23, 2024
21 checks passed
@grandizzy grandizzy deleted the chore-9161 branch October 23, 2024 09:55
leovct pushed a commit to leovct/foundry that referenced this pull request Oct 23, 2024
@grandizzy @leovct
chore: format chained error for EvmError (foundry-rs#9169)
00890cf
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@yash-atreya yash-atreya yash-atreya approved these changes

@DaniPopes DaniPopes Awaiting requested review from DaniPopes DaniPopes is a code owner

@klkvr klkvr Awaiting requested review from klkvr klkvr is a code owner

@mattsse mattsse Awaiting requested review from mattsse mattsse is a code owner

@zerosnacks zerosnacks Awaiting requested review from zerosnacks zerosnacks is a code owner

Assignees
No one assigned
Labels
None yet
Projects
Foundry
Status: No status
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@grandizzy @yash-atreya