fix(anvil): Apply state overrides in debug_traceCall #9172
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Co-authored-by: mixy1 <michael_debono@hotmail.com>
iliastsa
requested review from
DaniPopes,
klkvr,
mattsse,
grandizzy,
yash-atreya and
zerosnacks
as code owners
mattsse
approved these changes
Oct 23, 2024
auto-merge was automatically disabled
October 23, 2024 14:58
Head branch was pushed to by a user without write access
rplusq
pushed a commit
to rplusq/foundry
that referenced
this pull request
Nov 29, 2024
* fix(anvil): Apply state overrides in debug_traceCall Co-authored-by: mixy1 <michael_debono@hotmail.com> * chore(anvil): fix formatting --------- Co-authored-by: mixy1 <michael_debono@hotmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
State overrides are very useful when trying to simulate transactions. However, the
debug_traceCallimplementation did not apply the provided state overrides.Solution
The solution was to apply the state overrides similarly to the
eth_calllogic. I've also included a small test to verify that the patch is effective.