fix(anvil
): tag newly created legacy transactions on shadow fork as Some(0)
(0x0
) rather than None
#9195
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
Closes: #9194
Solution
Mark legacy transaction type as
0x0
orSome(0)
rather thanNone
This is in line with how Alloy marks legacy transactions
Steps to test:
In other window send a new transaction w/ default Anvil keys):
To verify the fix run step 2 with latest
anvil
installWill now correctly yield:
as opposed to
When querying existing legacy transactions the
transaction_type
is already correctly marked as0x0
.