feat(forge install): add @tag= @branch= @rev= specific refs
#9214
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
grandizzy
changed the title
forge install): add @tag= @branch= @commit= specific refsforge install): add @tag= @branch= @commit= specific refs
grandizzy
requested review from
DaniPopes,
klkvr,
mattsse,
yash-atreya and
zerosnacks
as code owners
zerosnacks
reviewed
Oct 28, 2024
zerosnacks
reviewed
Oct 28, 2024
crates/cli/src/opts/dependency.rs
Outdated
| assert_eq!(dep.tag, Some("contracts-ccip/v1.2.1".to_string())); | ||
| assert_eq!(dep.alias, None); | ||
|
|
||
| let dep = Dependency::from_str("smartcontractkit/ccip@commit=80eb41b").unwrap(); |
There was a problem hiding this comment.
Soldeer / Rust uses rev to refer to a commit, perhaps it makes sense to align here
There was a problem hiding this comment.
changed in e9d2967, please check
|
In favor of the proposed UX, few small notes |
grandizzy
changed the title
forge install): add @tag= @branch= @commit= specific refsforge install): add @tag= @branch= @rev= specific refs
zerosnacks
approved these changes
Oct 28, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
Closes #5996
Right now is hard to determine what
@is used to delimiter (if org, ref, etc.)Introduce
@tag=@branch=@rev=to specify ref type (and be able to handle/in tag / branch name without changing current behavior)Solution