Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(coverage): do not report empty constructors, enable reports for receive #9288

Merged
merged 1 commit into from
Nov 9, 2024

Conversation

grandizzy
Copy link
Collaborator

@grandizzy grandizzy commented Nov 8, 2024

Motivation

Closes #9270

Solution

  • do not count empty constructor as coverage function
  • receive anchor can now properly found, enable coverage report for
  • tests

@grandizzy grandizzy marked this pull request as ready for review November 8, 2024 16:23
@grandizzy grandizzy merged commit 91d3349 into foundry-rs:master Nov 9, 2024
21 checks passed
@grandizzy grandizzy deleted the issue-9270 branch November 9, 2024 05:40
rplusq pushed a commit to rplusq/foundry that referenced this pull request Nov 29, 2024
…receive` (foundry-rs#9288)

fix(coverage): do not report empty constructors, enable reports for receive fn
@grandizzy grandizzy added T-bug Type: bug C-forge Command: forge labels Dec 18, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
C-forge Command: forge T-bug Type: bug
Projects
None yet
Development

Successfully merging this pull request may close these issues.

bug: constructor() payable {} does not work correctly with code coverage
2 participants