Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(fork): set block blob_excess_gas_and_price only if excess_blob_gas header is Some #9298

Merged
merged 1 commit into from
Nov 11, 2024

Conversation

grandizzy
Copy link
Collaborator

@grandizzy grandizzy commented Nov 11, 2024

Motivation

Closes #9297

Solution

  • if no excess_blob_gas header then don't update env block block.blob_excess_gas_and_price
  • @zerosnacks @yash-atreya @klkvr this change pass tests but not sure if there are other side effects

@grandizzy grandizzy marked this pull request as ready for review November 11, 2024 16:19
Copy link
Member

@yash-atreya yash-atreya left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm!

Copy link
Member

@zerosnacks zerosnacks left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Proposed fix LGTM 👍

@grandizzy grandizzy merged commit 4817280 into foundry-rs:master Nov 11, 2024
21 checks passed
@grandizzy grandizzy deleted the issue-9297 branch November 11, 2024 16:39
rplusq pushed a commit to rplusq/foundry that referenced this pull request Nov 29, 2024
…as header` is Some (foundry-rs#9298)

fix(fork): set block blob_excess_gas_and_price only if excess_blob_gas header is Some
@grandizzy grandizzy added T-bug Type: bug C-forge Command: forge labels Dec 18, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
C-forge Command: forge T-bug Type: bug
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

vm.rollFork header validation error: excess_blob_gas
3 participants