-
Notifications
You must be signed in to change notification settings - Fork 1.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(forge): allow --verifier custom
option
#9311
Conversation
I think would be nice to have a foundry/crates/verify/src/verify.rs Line 36 in 54ea38d
|
…essage, add custom verifier api key
de03128
to
848c244
Compare
Co-authored-by: zerosnacks <95942363+zerosnacks@users.noreply.github.com>
Having hardtime to verify contract on Core Testnet (EVM Compatible)
CLI Command: Respond:
Api key checking: Respond: |
@d-democrazy looks like Block explorer is not etherscan API compatible, so not much we could do here, custom verifiers requires such |
feat(forge): allow `--verifier custom` option (foundry-rs#9311)
* feat(forge): allow `--verifier custom` option * Changes after review: add description of custom verifier, reorg err message, add custom verifier api key * Fix descriptions * Update crates/verify/src/provider.rs Co-authored-by: zerosnacks <95942363+zerosnacks@users.noreply.github.com> --------- Co-authored-by: zerosnacks <95942363+zerosnacks@users.noreply.github.com>
Motivation
Closes #9220
Closes #8254
Closes #7466 (no need to pass
chain
param as it will be retrieved from provider / --rpc-url)Closes #8100
--verifier custom
. adds--verifier-api-key
for custom verifier keysor defined and implicitly taken from
foundry.toml
config, e.g.Solution