Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(forge build): err if no source file in specified paths #9329

Merged
merged 1 commit into from
Nov 15, 2024

Conversation

grandizzy
Copy link
Collaborator

Motivation

Closes #9304

Opted to fail (instead warn) if no source file matches provided build paths

Solution

Copy link
Member

@zerosnacks zerosnacks left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't think there are side effects of this proposed change

Supportive of this being an error rather than a warning, this is in line with other commands when specifying a path and there was no match

@grandizzy grandizzy merged commit 9d7557f into foundry-rs:master Nov 15, 2024
21 checks passed
@grandizzy grandizzy deleted the issue-9304 branch November 15, 2024 14:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: No status
Development

Successfully merging this pull request may close these issues.

Raise warning if path specified in forge build does not match and fallback is triggered
2 participants