Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: identification of contracts in scripts #9346

Merged
merged 2 commits into from
Nov 18, 2024
Merged

fix: identification of contracts in scripts #9346

merged 2 commits into from
Nov 18, 2024

Conversation

klkvr
Copy link
Member

@klkvr klkvr commented Nov 18, 2024 •
edited
Loading

Motivation

Right now this would fail if there're any contracts with the same name in project due to

foundry/crates/common/src/contracts.rs

Lines 255 to 257 in 2dcc84f

if contracts.len() > 1 {
eyre::bail!("{id} has more than one implementation.");
}

Solution

Use complete identifier when getting artifact

@mattsse
Copy link
Member

mattsse commented Nov 18, 2024

failure unrelated

@mattsse mattsse merged commit c13d42e into master Nov 18, 2024
19 of 21 checks passed
@mattsse mattsse deleted the klkvr/fix-script-identification branch November 18, 2024 21:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mattsse mattsse mattsse approved these changes

@DaniPopes DaniPopes Awaiting requested review from DaniPopes DaniPopes is a code owner

@grandizzy grandizzy Awaiting requested review from grandizzy grandizzy is a code owner

@yash-atreya yash-atreya Awaiting requested review from yash-atreya yash-atreya is a code owner

@zerosnacks zerosnacks Awaiting requested review from zerosnacks zerosnacks is a code owner

Assignees
No one assigned
Labels
None yet
Projects
Foundry
Status: No status
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@klkvr @mattsse