Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore(ci): archive endpoints config #9348

Merged
merged 7 commits into from
Nov 19, 2024
Merged

chore(ci): archive endpoints config #9348

merged 7 commits into from
Nov 19, 2024

Conversation

grandizzy
Copy link
Collaborator

@grandizzy grandizzy commented Nov 19, 2024 •
edited
Loading

Motivation

Solution

  • allow configuring of endpoints (only archive for now, as they're mostly handling all heavy tests / requests) as WS_ARCHIVE_URLS and HTTP_ARCHIVE_URLS env vars. comma separated URLs
  • truncate fork url in err message
  • use infura for default archive endpoints

@grandizzy grandizzy changed the title chore: move archive endpoints to different provider chore(ci): archive endpoints config Nov 19, 2024
@grandizzy grandizzy marked this pull request as ready for review November 19, 2024 09:34
@zerosnacks zerosnacks self-requested a review November 19, 2024 12:23
@grandizzy
Copy link
Collaborator Author

grandizzy commented Nov 19, 2024 •
edited by DaniPopes
Loading

failure on external forge-std https://github.com/foundry-rs/foundry/actions/runs/11916215232/job/33208365964#step:12:2902 should be fixed by foundry-rs/forge-std#632

@mattsse mattsse merged commit 7538c4e into foundry-rs:master Nov 19, 2024
22 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@zerosnacks zerosnacks zerosnacks approved these changes

@mattsse mattsse mattsse approved these changes

@DaniPopes DaniPopes Awaiting requested review from DaniPopes DaniPopes is a code owner

@klkvr klkvr Awaiting requested review from klkvr klkvr is a code owner

@yash-atreya yash-atreya Awaiting requested review from yash-atreya yash-atreya is a code owner

Assignees
No one assigned
Labels
None yet
Projects
Foundry
Status: No status
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@grandizzy @mattsse @zerosnacks