chore: make environment variable error nicer #9353
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
DaniPopes
requested review from
klkvr,
mattsse,
grandizzy,
yash-atreya and
zerosnacks
as code owners
zerosnacks
approved these changes
Nov 19, 2024
DaniPopes
force-pushed
the
dani/env-error
branch
from
249cb00
to
a6a8ae4
Compare
mattsse
approved these changes
Nov 19, 2024
|
Forge-std failure: foundry-rs/forge-std#632 |
DaniPopes
added a commit
to foundry-rs/forge-std
that referenced
this pull request
Nov 19, 2024
There are no stability guarantees about error messages. This specific error message was changed in foundry-rs/foundry#9353.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Before:
[FAIL: setup failed: vm.createSelectFork: Failed to resolve env var `ETH_NODE_URI_MAINNET` in `${ETH_NODE_URI_MAINNET}`: environment variable not found] setUp() (gas: 0)After:
[FAIL: setup failed: vm.createSelectFork: environment variable `ETH_NODE_URI_MAINNET` not found] setUp() (gas: 0)