fix(forge test): install missing dependencies before creating Project
#9379
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
klkvr
requested review from
DaniPopes,
mattsse,
grandizzy,
yash-atreya and
zerosnacks
as code owners
2 tasks
rplusq
pushed a commit
to rplusq/foundry
that referenced
this pull request
Nov 29, 2024
…t` (foundry-rs#9379) * fix(forge test): install missing dependencies before instantiating the project * optimization
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
Closes #9375
With #8668 we now resolve the
Graphwhen creating project as we need data about all sources for restrictions. This causedforge testto fail in CI if there are any missing dependencies which were being installed only after call toconfig.project()This PR changes order of operations so that we always install dependencies first. Also I've added an optimization to skip graph resolution if user did not specify any restrictions