feat(cast): decode-error with sig, local cache and openchain api
#9428
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
grandizzy
changed the title
decode-error with sig and local cache
grandizzy
changed the title
decode-error with sig and local cachecast): decode-error with sig and local cache
grandizzy
requested review from
DaniPopes,
klkvr,
mattsse,
yash-atreya and
zerosnacks
as code owners
zerosnacks
reviewed
Nov 28, 2024
zerosnacks
reviewed
Nov 28, 2024
DaniPopes
requested changes
Nov 28, 2024
grandizzy
changed the title
cast): decode-error with sig and local cachecast): decode-error with sig, local cache and openchain api
DaniPopes
reviewed
Nov 28, 2024
crates/cast/bin/main.rs
Outdated
| .await | ||
| .identify_error(&hex::decode(selector)?) | ||
| .await; | ||
| if err.is_none() { |
There was a problem hiding this comment.
changed in 1834215
| DecodeError { | ||
| /// The error signature. If none provided then tries to decode from local cache or `https://api.openchain.xyz`. | ||
| #[arg(long, visible_alias = "error-sig")] | ||
| sig: Option<String>, |
There was a problem hiding this comment.
can we make this optional for decode event too? followup
There was a problem hiding this comment.
yep, will follow up with a PR, have to figure out how to parse with topics
DaniPopes
approved these changes
Nov 29, 2024
rplusq
pushed a commit
to rplusq/foundry
that referenced
this pull request
Nov 29, 2024
…oundry-rs#9428) * feat(cast): Add custom error decoding support * Review changes * Changes after review: decode with Openchain too, add test * Review changes: nit, handle incomplete selectors
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
cast decode-error [OPTIONS] <DATA>command: if--sigarg specified then it tries to decode data with given signature; if no--sigthen tries to identify error in local cache or openchain API and decode with. For identified errors, the signature is printed in responseforge selectors cachewithin projectSolution