feat: allow any config to be defined inline #9430
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
DaniPopes
requested review from
klkvr,
mattsse,
grandizzy,
yash-atreya and
zerosnacks
as code owners
DaniPopes
commented
Nov 29, 2024
grandizzy
reviewed
Nov 29, 2024
There was a problem hiding this comment.
Awesome stuff! gave #6228 (comment) a try with inline paris and shanghai and works great. I think this PR should close #6228 too per #6228 (comment) (1st and 3rd bullets are covered in this PR, the 2nd bullet / automatic detection is tracked in #6440)
should we clean up tests a little bit too (like merging testdata/paris in testdata/default and removing the TEST_DATA_PARIS / paris ForgeTestProfile profile and using inline config for specifying the evm version), or better to keep separate profiles? (I can follow up in a PR after we merge this one)
zerosnacks
approved these changes
Dec 2, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Allow any configuration value to be defined inline using the same TOML syntax as foundry.toml.
This is achieved by updating
Config,Executoretc. fields with the new inlineConfigvalue saved in aTestRunnerConfigfield for each level of tests:MultiContractRunner, globalContractRunner, contract-level, applied before running any EVM codeFunctionRunner(new), function-level, applied before running each testTestRunnerConfigis inherited from the level before, and updated with inline config whenever it's available.Not all configs will do something at every level; for example the fork stuff is spawned at contract-level so changing that at function level won't have any effect, but for that there is cheatcodes.
TestOptions's functionality has been moved toFunctionRunner.Closes #8564.
Closes #6908.
Closes #6228.