Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(fuzz): exclude exernal libraries addresses from fuzz inputs #9527

Merged
merged 1 commit into from
Dec 10, 2024

Conversation

grandizzy
Copy link
Collaborator

@grandizzy grandizzy commented Dec 10, 2024

Motivation

Closes #8639

Solution

  • Collect addresses of external deployed libraries within test setup
  • filter addresses in fuzzed strategy from state
  • test

@@ -742,8 +742,8 @@ async fn test_trace() {

assert_eq!(
deployment_traces.count(),
12,
"Test {test_name} did not have exactly 12 deployment trace."
13,
Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

new deployment trace added by the external library test

@grandizzy grandizzy marked this pull request as ready for review December 10, 2024 11:20
Copy link
Member

@yash-atreya yash-atreya left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

Copy link
Member

@zerosnacks zerosnacks left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@grandizzy grandizzy merged commit 59f354c into foundry-rs:master Dec 10, 2024
22 checks passed
@grandizzy grandizzy deleted the fix-8639 branch December 10, 2024 16:08
@grandizzy grandizzy added T-bug Type: bug C-forge Command: forge labels Dec 18, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
C-forge Command: forge T-bug Type: bug
Projects
Status: No status
Development

Successfully merging this pull request may close these issues.

bug: state appears to be shared between tests when linked libraries are used
3 participants