Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(cheatcodes): clear orderings together with trace steps on debug trace stop #9529

Merged
merged 2 commits into from
Dec 10, 2024
Merged

fix(cheatcodes): clear orderings together with trace steps on debug trace stop #9529

merged 2 commits into from
Dec 10, 2024

Conversation

grandizzy
Copy link
Collaborator

@grandizzy grandizzy commented Dec 10, 2024 •
edited
Loading

Motivation

Closes #9526

  • clear ordering and node logs too together with node trace steps

Solution

@grandizzy grandizzy changed the title fix(cheatcodes): stopAndReturnDebugTraceRecordingCall clear node logs too fix(cheatcodes): clear orderings together with trace steps on debug trace stop Dec 10, 2024
@grandizzy grandizzy marked this pull request as ready for review December 10, 2024 13:24
@grandizzy grandizzy enabled auto-merge (squash) December 10, 2024 13:24
zerosnacks
zerosnacks approved these changes Dec 10, 2024
View reviewed changes
Copy link
Member

@zerosnacks zerosnacks left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

makes sense 👍

@grandizzy grandizzy merged commit b090638 into foundry-rs:master Dec 10, 2024
22 checks passed
@grandizzy grandizzy deleted the issue-9526 branch December 10, 2024 13:34
@grandizzy grandizzy added T-bug Type: bug C-forge Command: forge labels Dec 18, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@zerosnacks zerosnacks zerosnacks approved these changes

@DaniPopes DaniPopes Awaiting requested review from DaniPopes DaniPopes is a code owner

@klkvr klkvr Awaiting requested review from klkvr klkvr is a code owner

@mattsse mattsse Awaiting requested review from mattsse mattsse is a code owner

@yash-atreya yash-atreya Awaiting requested review from yash-atreya yash-atreya is a code owner

Assignees
No one assigned
Labels
C-forge Command: forge T-bug Type: bug
Projects
Foundry
Status: No status
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Panic resulting from verbosity increased to 4 when using startDebugTraceRecording
2 participants
@grandizzy @zerosnacks