fix(evm): P256Verify address
#9618
Merged
+3
−2
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
yash-atreya
requested review from
DaniPopes,
klkvr,
mattsse,
grandizzy and
zerosnacks
as code owners
mattsse
requested changes
Jan 3, 2025
crates/evm/core/src/precompiles.rs
Outdated
| @@ -52,7 +52,7 @@ pub const PRECOMPILES: &[Address] = &[ | |||
| /// [EIP-7212](https://eips.ethereum.org/EIPS/eip-7212) secp256r1 precompile address on Odyssey. | |||
| /// | |||
| /// <https://github.com/ithacaxyz/odyssey/blob/482f4547631ae5c64ebea6a4b4ef93184a4abfee/crates/node/src/evm.rs#L35-L35> | |||
| pub const ODYSSEY_P256_ADDRESS: Address = address!("0000000000000000000000000000000000000014"); | |||
| pub const ODYSSEY_P256_ADDRESS: Address = address!("0000000000000000000000000000000000000100"); | |||
There was a problem hiding this comment.
we deployed on 0x14 and will keep that address for odyssey, the 0x100 is the proposed RIP address, I think we should just add the precompile to both addresses instead, IIRC revm has a constant for 0x100
mattsse
approved these changes
Jan 3, 2025
zerosnacks
approved these changes
Jan 3, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
Currently the
P256Verifyis injected at the wrong address i.e0x14.Solution
Inject it at
0x100according to the spec: https://github.com/ethereum/RIPs/blob/master/RIPS/rip-7212.md#specification.Maintains backward compatibility by also injecting it at 0x14.