Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(config): normalize optimizer settings #9689

Merged
merged 1 commit into from
Jan 16, 2025
Merged

fix(config): normalize optimizer settings #9689

merged 1 commit into from
Jan 16, 2025

Conversation

grandizzy
Copy link
Collaborator

@grandizzy grandizzy commented Jan 16, 2025 •
edited
Loading

Motivation

Closes #9688

Solution

  • move optimizer settings normalization in helper fn and reuse when generating configs
  • add tests for default configs and optimizer options

@grandizzy grandizzy marked this pull request as ready for review January 16, 2025 09:33
DaniPopes
DaniPopes approved these changes Jan 16, 2025
View reviewed changes
Copy link
Member

@DaniPopes DaniPopes left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@grandizzy grandizzy added T-bug Type: bug C-forge Command: forge labels Jan 16, 2025
@grandizzy grandizzy merged commit 9829054 into foundry-rs:master Jan 16, 2025
22 checks passed
@grandizzy grandizzy deleted the issue-9688 branch January 16, 2025 10:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@DaniPopes DaniPopes DaniPopes approved these changes

@klkvr klkvr Awaiting requested review from klkvr klkvr is a code owner

@mattsse mattsse Awaiting requested review from mattsse mattsse is a code owner

@yash-atreya yash-atreya Awaiting requested review from yash-atreya yash-atreya is a code owner

@zerosnacks zerosnacks Awaiting requested review from zerosnacks zerosnacks is a code owner

Assignees
No one assigned
Labels
C-forge Command: forge T-bug Type: bug
Projects
Foundry
Status: No status
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

bug: forge config with default values does not dump proper optimizer / optimizer_runs
2 participants
@grandizzy @DaniPopes