Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(forge): allow install private deps with https and gh token #9726

Merged
merged 1 commit into from
Jan 21, 2025
Merged

fix(forge): allow install private deps with https and gh token #9726

merged 1 commit into from
Jan 21, 2025

Conversation

grandizzy
Copy link
Collaborator

@grandizzy grandizzy commented Jan 21, 2025 •
edited
Loading

Motivation

closes #9717

Solution

  • update GH REPO regex to allow https://gh_token@url format, capture and apply token

@grandizzy grandizzy marked this pull request as ready for review January 21, 2025 10:04
@grandizzy grandizzy merged commit f94ce46 into foundry-rs:master Jan 21, 2025
22 checks passed
@grandizzy grandizzy deleted the issue-9717 branch January 21, 2025 10:54
@grandizzy grandizzy added T-feature Type: feature C-forge Command: forge labels Jan 30, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@yash-atreya yash-atreya yash-atreya approved these changes

@zerosnacks zerosnacks zerosnacks approved these changes

@DaniPopes DaniPopes Awaiting requested review from DaniPopes DaniPopes is a code owner

@klkvr klkvr Awaiting requested review from klkvr klkvr is a code owner

@mattsse mattsse Awaiting requested review from mattsse mattsse is a code owner

Assignees
No one assigned
Labels
C-forge Command: forge T-feature Type: feature
Projects
Foundry
Status: No status
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Installing private repository as depedencies is not working
3 participants
@grandizzy @yash-atreya @zerosnacks