fix(forge bind): prefix keyword mod names with r#
#9761
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
yash-atreya
requested review from
DaniPopes,
klkvr,
mattsse,
grandizzy and
zerosnacks
as code owners
yash-atreya
changed the title
forge bind): prefix keyword mod names with r#forge bind): prefix keyword mod names with r#
mattsse
approved these changes
Jan 27, 2025
|
|
||
| fn write_mod_name(contents: &mut String, name: &str) -> Result<()> { | ||
| if syn::parse_str::<syn::File>(&format!("pub mod {name};")) | ||
| .is_err_and(|e| e.to_string().contains("expected identifier, found keyword")) |
There was a problem hiding this comment.
this should do it, alternatively we could try to parse name as Ident perhaps?
There was a problem hiding this comment.
should be syn::parse_str::<Ident>().is_ok()
DaniPopes
previously requested changes
Jan 27, 2025
|
|
||
| fn write_mod_name(contents: &mut String, name: &str) -> Result<()> { | ||
| if syn::parse_str::<syn::File>(&format!("pub mod {name};")) | ||
| .is_err_and(|e| e.to_string().contains("expected identifier, found keyword")) |
There was a problem hiding this comment.
should be syn::parse_str::<Ident>().is_ok()
mattsse
approved these changes
Jan 27, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
Closes #5847
Solution
Prefix keyword module names with
r#.E.g.