Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Migrate all scarb packages to support edition = "2024_07" #2651

Open
kkawula opened this issue Nov 7, 2024 · 15 comments
Open

Migrate all scarb packages to support edition = "2024_07" #2651

kkawula opened this issue Nov 7, 2024 · 15 comments
Assignees
Labels
good first issue Good for newcomers new

Comments

@kkawula
Copy link
Collaborator

kkawula commented Nov 7, 2024

Which components does the task require to be changed? (think hard pls)

snforge, sncast

Description

Migrate all scarb packages to support edition = "2024_07"

Sollution:
for each

  • change edition to "2024_07"
  • run snforge test to check if the package compiles
    if not make proper changes

Related: #2632

@enehizy
Copy link

enehizy commented Nov 7, 2024

Mind if I take this issue?

@OWK50GA
Copy link

OWK50GA commented Nov 7, 2024

Could I take on this issue?

@mexes20
Copy link

mexes20 commented Nov 7, 2024

Hello, I’d like to be assigned to work on this.

ETA: 15 hours

@pheobeayo
Copy link

I'd love to give this a go.

@ShantelPeters
Copy link

Please can I be assigned to this issue

@PedroRosalba
Copy link

I am applying to this issue via OnlyDust platform.

My background and how it can be leveraged

How I plan on tackling this issue

@pheobeayo
Copy link

On it! thank you for the task.

@franciszekjob
Copy link
Collaborator

Hi @pheobeayo , just wanted to check out on your progress. Do you need any assistance 😄 ?

@pheobeayo
Copy link

@franciszekjob I am working on it, but how do I build successfully locally?

@franciszekjob
Copy link
Collaborator

franciszekjob commented Nov 14, 2024

but how do I build successfully locally?

Just run snforge test in the package.

@franciszekjob
Copy link
Collaborator

Hi @pheobeayo , how's the progress :) ?

@pheobeayo
Copy link

@franciszekjob still fixing the 507 bugs after changing the edition....

I have tried fixing some but still couldn't make the file public like this lib.cairo was initially like
image
but I decided to make it public like this
image
but still couldn't compile.....

Any clue to that

@franciszekjob
Copy link
Collaborator

@pheobeayo I see you're updating edition in snforge_std. I think we can address this specific package in other PR, as it may require more work. So let's limit the scope to update edition in all packages, apart of snforge_std, ok?

@pheobeayo pheobeayo mentioned this issue Nov 17, 2024
4 tasks
@pheobeayo
Copy link

okay

@pheobeayo
Copy link

@franciszekjob Kindly check out the PR I created yesterday, I updated the edition in all packages apart from the snforge_std

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
good first issue Good for newcomers new
Projects
Status: In Progress
Development

No branches or pull requests

8 participants