Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add missing edition field to Scarb packages in the repository #2632

Closed
cptartur opened this issue Oct 31, 2024 · 0 comments · Fixed by #2649
Closed

Add missing edition field to Scarb packages in the repository #2632

cptartur opened this issue Oct 31, 2024 · 0 comments · Fixed by #2649
Assignees
@kkawula
Labels
maintenance sncast snforge

Comments

@cptartur
Copy link
Member

cptartur commented Oct 31, 2024 •
edited
Loading

In the upcoming Scarb 2.9.0, a warning will be thrown in case of package without defined edition field.

Set it so that using packages from our repo (like snforge_std) doesn't cause these warnings for the users.
@cptartur cptartur converted this from a draft issue Oct 31, 2024
@github-actions github-actions bot added the new label Oct 31, 2024
This was referenced Nov 7, 2024
Merged
Open
github-merge-queue bot pushed a commit that referenced this issue Nov 7, 2024
@kkawula
Add edition entry in each Scarb.toml (#2649)
8eb8ca8 
<!-- Reference any GitHub issues resolved by this PR -->

Closes #2632

## Introduced changes

<!-- A brief description of the changes -->

-

## Checklist

<!-- Make sure all of these are complete -->

- [x] Linked relevant issue
- [x] Updated relevant documentation
- [x] Added relevant tests
- [x] Performed self-review of the code
- [x] Added changes to `CHANGELOG.md`
@github-project-automation github-project-automation bot moved this from TODO to Done in Starknet foundry Nov 7, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@kkawula kkawula

Labels
maintenance sncast snforge
Projects
Starknet foundry
Status: Done
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Add edition entry in each Scarb.toml foundry-rs/starknet-foundry
2 participants
@cptartur @kkawula