Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add edition entry in each Scarb.toml #2649

Conversation

kkawula
Copy link
Collaborator

@kkawula kkawula commented Nov 7, 2024

Closes #2632

Introduced changes

Checklist

  • Linked relevant issue
  • Updated relevant documentation
  • Added relevant tests
  • Performed self-review of the code
  • Added changes to CHANGELOG.md

@kkawula
Copy link
Collaborator Author

kkawula commented Nov 7, 2024

Tried to add the latest version possible.

@kkawula kkawula marked this pull request as ready for review November 7, 2024 13:37
Copy link
Collaborator

@franciszekjob franciszekjob left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

What if for some reason someone adds a package which doesn't have edition entry in its Scarb.toml? I believe we will not notice it. I think we should add test which would check this.

See this CI step which searches for all packages and check their formatting. We could add a similar one (display content of Scarb.toml and capture edition entry) - its shouldn't be a big effort.

@cptartur
Copy link
Member

cptartur commented Nov 7, 2024

What if for some reason someone adds a package which doesn't have edition entry in its Scarb.toml? I believe we will not notice it. I think we should add test which would check this.

See this CI step which searches for all packages and check their formatting. We could add a similar one (display content of Scarb.toml and capture edition entry) - its shouldn't be a big effort.

Scarb 2.9.0 will emit a warning. Once we have tests running on different versions of Scarb, this could be testable without writing a script.

I'd create an issue and postpone resolving that until that is resolved.

Copy link
Member

@cptartur cptartur left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Let's create a follow-up issue to migrate them all to 2024_07.

@kkawula kkawula added this pull request to the merge queue Nov 7, 2024
Merged via the queue into master with commit 8eb8ca8 Nov 7, 2024
25 checks passed
@kkawula kkawula deleted the kkawula/2632-add-missing-edition-field-to-scarb-packages-in-the-repository branch November 7, 2024 15:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add missing edition field to Scarb packages in the repository
3 participants