-
Notifications
You must be signed in to change notification settings - Fork 177
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add edition entry in each Scarb.toml
#2649
Add edition entry in each Scarb.toml
#2649
Conversation
Tried to add the latest version possible. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
What if for some reason someone adds a package which doesn't have edition
entry in its Scarb.toml
? I believe we will not notice it. I think we should add test which would check this.
See this CI step which searches for all packages and check their formatting. We could add a similar one (display content of Scarb.toml
and capture edition
entry) - its shouldn't be a big effort.
Scarb 2.9.0 will emit a warning. Once we have tests running on different versions of Scarb, this could be testable without writing a script. I'd create an issue and postpone resolving that until that is resolved. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Let's create a follow-up issue to migrate them all to 2024_07.
Closes #2632
Introduced changes
Checklist
CHANGELOG.md