Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Enforce fuzzer_runs >= 1 everywhere #1938

Merged
merged 7 commits into from
Mar 27, 2024
Merged

Enforce fuzzer_runs >= 1 everywhere #1938

merged 7 commits into from
Mar 27, 2024

Conversation

Draggu
Copy link
Contributor

@Draggu Draggu commented Mar 26, 2024 •
edited
Loading

Related #1435

Introduced changes

  • Enforce fuzzer_runs >= 1 everywhere

Checklist

  • Linked relevant issue
  • Updated relevant documentation
  • Added relevant tests
  • Performed self-review of the code
  • Added changes to CHANGELOG.md

@Draggu Draggu requested a review from a team as a code owner March 26, 2024 11:36
@Draggu Draggu requested review from Arcticae and drknzz and removed request for a team March 26, 2024 11:36
Arcticae
Arcticae reviewed Mar 26, 2024
View reviewed changes
crates/forge-runner/src/fuzzer.rs Outdated Show resolved Hide resolved
crates/forge/src/main.rs Outdated Show resolved Hide resolved
piotmag769
piotmag769 reviewed Mar 26, 2024
View reviewed changes
Copy link
Member

@piotmag769 piotmag769 left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Logic looks good, but please change it in the test collector in Scarb too (we lack the non-zero validation there I believe so it may result in panic in forge)

crates/forge-runner/src/fuzzer.rs Outdated Show resolved Hide resolved
crates/forge-runner/src/fuzzer/random.rs Outdated Show resolved Hide resolved
crates/forge-runner/src/fuzzer.rs Outdated Show resolved Hide resolved
crates/forge-runner/src/fuzzer/random.rs Show resolved Hide resolved
@Draggu Draggu requested a review from Arcticae March 27, 2024 10:39
@Draggu Draggu mentioned this pull request Mar 27, 2024
Merged
@Draggu Draggu added this pull request to the merge queue Mar 27, 2024
Merged via the queue into master with commit 06031a2 Mar 27, 2024
13 checks passed
@Draggu Draggu deleted the fuzzer-runs branch March 27, 2024 11:36
github-merge-queue bot pushed a commit to software-mansion/scarb that referenced this pull request Mar 27, 2024
@Draggu
Enforce fuzzer_runs >= 1 in snforge-test-collector (#1231)
cb354c6 
Closes foundry-rs/starknet-foundry#1435

On `snforge` side
foundry-rs/starknet-foundry#1938
maciektr pushed a commit to software-mansion/scarb that referenced this pull request Jun 11, 2024
@Draggu @maciektr
Enforce fuzzer_runs >= 1 in snforge-test-collector (#1231)
4294a01 
Closes foundry-rs/starknet-foundry#1435

On `snforge` side
foundry-rs/starknet-foundry#1938
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@piotmag769 piotmag769 piotmag769 approved these changes

@Arcticae Arcticae Arcticae approved these changes

@drknzz drknzz Awaiting requested review from drknzz drknzz was automatically assigned from foundry-rs/starknet-foundry-forge

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@Draggu @Arcticae @piotmag769