Feat add exclude pattern running tests #2361
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
julienbrs
requested review from
ksew1,
tomek0123456789,
integraledelebesgue and
cptartur
as code owners
integraledelebesgue
requested changes
Aug 21, 2024
|
Please fill the checklist and add your changes to the changelog :) |
|
Also, always make sure to run |
|
Hi! This pull request hasn't had any activity for a while, so I am |
kkawula
requested changes
Feb 10, 2025
Comment on lines
+189
to
+190
| #[arg(long)] | ||
| exclude_filter: Option<String>, |
There was a problem hiding this comment.
I would call it "exclude" in CLI
| @@ -208,7 +212,7 @@ pub struct NewArgs { | |||
| /// Do not initialize a new Git repository | |||
| #[arg(long)] | |||
| no_vcs: bool, | |||
| /// Try to create the project even if the specified directory at <PATH> is not empty, which can result in overwriting existing files | |||
There was a problem hiding this comment.
What's the reason of this change?
| @@ -85,6 +85,7 @@ impl RunForPackageArgs { | |||
| args.include_ignored, | |||
| args.rerun_failed, | |||
| FailedTestsCache::new(cache_dir), | |||
| args.exclude_filter.clone(), | |||
Comment on lines
+51
to
+53
| if tests_filter.is_excluded(&case) { | ||
| continue; | ||
| } |
There was a problem hiding this comment.
TestCaseSummary should be pushed to tasks as below
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #1512
Introduced changes
--excludeflag that functions similarly to the existingFilterName. This flag allows users to exclude tests based on their names.snforge test simple_testlaunches all tests beginning with "simple_test", rather than requiringsnforge test --filter simple_test). Given this, I believe the new--excludeoption might not be compatible with the existing filter option. What do you think?Checklist
CHANGELOG.md