Feat: generate random felt #2634
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
manlikeHB
requested review from
cptartur,
ddoktorski,
kkawula and
franciszekjob
as code owners
|
Hi @cptartur, PR ready for review. |
kkawula
reviewed
Nov 4, 2024
kkawula
reviewed
Nov 4, 2024
kkawula
requested changes
Nov 4, 2024
There was a problem hiding this comment.
- Please revert the documentation format change. Probably your IDE has configured style for
mdfile and refactored it entirely on save. I meanCHANGELOG.mdSUMMARY.mdgenerate_random_felt.md - Add e2e test, examples: https://github.com/foundry-rs/starknet-foundry/blob/master/crates/forge/tests/e2e/running.rs
cptartur
requested changes
Nov 4, 2024
...s/cheatnet/src/runtime_extensions/forge_runtime_extension/cheatcodes/generate_random_felt.rs
Outdated
Show resolved
Hide resolved
manlikeHB
force-pushed
the
feat-generate-random-felt
branch
from
f50bd80
to
8413d5e
Compare
|
@kkawula Clippy CI error fixed. |
cptartur
requested changes
Nov 5, 2024
manlikeHB
force-pushed
the
feat-generate-random-felt
branch
from
dbf0076
to
2054fc9
Compare
cptartur
approved these changes
Nov 6, 2024
kkawula
approved these changes
Nov 6, 2024
auto-merge was automatically disabled
November 6, 2024 12:50
Head branch was pushed to by a user without write access
5 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #2353
Introduced changes
Checklist
CHANGELOG.md