Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add scheduled workflow to test against different Scarb versions #2662

Merged
merged 5 commits into from
Nov 19, 2024
Merged

Add scheduled workflow to test against different Scarb versions #2662

merged 5 commits into from
Nov 19, 2024

Conversation

ddoktorski
Copy link
Contributor

@ddoktorski ddoktorski commented Nov 12, 2024 •
edited
Loading

Closes #2578

Introduced changes

  • Added a scheduled workflow to run all unit, integration and e2e tests for sncast and snforge for different Scarb versions, every Wednesday and Sunday at 0:00 UTC

Checklist

  • Linked relevant issue
  • Updated relevant documentation
  • Added relevant tests
  • Performed self-review of the code
  • Added changes to CHANGELOG.md

Base automatically changed from 2578-ensure-tests-work-for-different-scarb-versions to master November 13, 2024 13:17
@ddoktorski ddoktorski force-pushed the 2578-automatic-testing-different-scarb-versions branch from 9b60196 to b266844 Compare November 18, 2024 11:17
@ddoktorski ddoktorski marked this pull request as ready for review November 18, 2024 11:56
cptartur
cptartur reviewed Nov 18, 2024
View reviewed changes
Copy link
Member

@cptartur cptartur left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@THenry14 can you review please?

.github/workflows/scheduled.yml Outdated Show resolved Hide resolved
.github/workflows/scheduled.yml Show resolved Hide resolved
scripts/get_scarb_versions.sh Show resolved Hide resolved
scripts/get_scarb_versions.sh Outdated Show resolved Hide resolved
@ddoktorski ddoktorski mentioned this pull request Nov 18, 2024
Open
THenry14
THenry14 reviewed Nov 19, 2024
View reviewed changes
.github/workflows/scheduled.yml Outdated Show resolved Hide resolved
.github/workflows/scheduled.yml Show resolved Hide resolved
scripts/get_scarb_versions.sh Outdated Show resolved Hide resolved
scripts/get_scarb_versions.sh Show resolved Hide resolved
scripts/get_scarb_versions.sh Outdated Show resolved Hide resolved
scripts/get_scarb_versions.sh Outdated Show resolved Hide resolved
@ddoktorski ddoktorski added this pull request to the merge queue Nov 19, 2024
@github-merge-queue github-merge-queue bot removed this pull request from the merge queue due to failed status checks Nov 19, 2024
@ddoktorski ddoktorski added this pull request to the merge queue Nov 19, 2024
Merged via the queue into master with commit a40d23a Nov 19, 2024
46 checks passed
@ddoktorski ddoktorski deleted the 2578-automatic-testing-different-scarb-versions branch November 19, 2024 14:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@cptartur cptartur cptartur approved these changes

@THenry14 THenry14 THenry14 approved these changes

@kkawula kkawula Awaiting requested review from kkawula kkawula is a code owner

@franciszekjob franciszekjob Awaiting requested review from franciszekjob franciszekjob is a code owner

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Automatic testing of foundry against different Scarb versions
3 participants
@ddoktorski @THenry14 @cptartur