Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add data transformer examples to docs #2682

Open
wants to merge 9 commits into
base: master
Choose a base branch
from
Open

Add data transformer examples to docs #2682

wants to merge 9 commits into from
+47 −35

Conversation

kkawula
Copy link
Collaborator

@kkawula kkawula commented Nov 18, 2024 •
edited
Loading

Closes #2557

Introduced changes

Checklist

  • Linked relevant issue
  • Updated relevant documentation
  • Added relevant tests
  • Performed self-review of the code
  • Added changes to CHANGELOG.md

@kkawula kkawula marked this pull request as ready for review November 19, 2024 09:05
cptartur
cptartur requested changes Nov 20, 2024
View reviewed changes
crates/sncast/README.md Outdated Show resolved Hide resolved
docs/src/starknet/index.md Outdated Show resolved Hide resolved
docs/src/starknet/index.md Outdated Show resolved Hide resolved
franciszekjob
franciszekjob reviewed Nov 21, 2024
View reviewed changes
Copy link
Collaborator

@franciszekjob franciszekjob left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

These examples (snippets + outputs) rely on example contract(s) present in our code, right?

docs/src/starknet/index.md Outdated Show resolved Hide resolved
@kkawula
Copy link
Collaborator Author

kkawula commented Nov 21, 2024

These examples (snippets + outputs) rely on example contract(s) present in our code, right?

I've created it using my own Pokemon contract to achieve more complex example

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@franciszekjob franciszekjob franciszekjob left review comments

@ddoktorski ddoktorski Awaiting requested review from ddoktorski ddoktorski is a code owner

@cptartur cptartur Awaiting requested review from cptartur cptartur is a code owner

Requested changes must be addressed to merge this pull request.

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Update sncast docs to use data transformer instead of serialized calldata as a default exampl
3 participants
@kkawula @cptartur @franciszekjob