[#1401] Item Choice Advancement #2015
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
arbron
force-pushed
the
advancement/item-choice-rework
branch
2 times, most recently
from
b91b30c
to
b2c12ab
Compare
arbron
changed the title
arbron
force-pushed
the
advancement/item-choice-rework
branch
from
b2c12ab
to
104a543
Compare
Fyorl
requested changes
Jan 4, 2023
arbron
force-pushed
the
advancement/item-choice-rework
branch
from
8a9b4f9
to
eb0de39
Compare
arbron
force-pushed
the
advancement/item-choice-rework
branch
from
009c8fe
to
b2992c1
Compare
Fyorl
approved these changes
Jan 17, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Introduces the item choice advancement for choosing one or more options when you reach a level, usable for things like Fighting Style, Metamagic, or Signature Spells.
The player can select an option from a predefined list like Fighting Style:
Item.Choice.-.Basic.webm
Or they can drop items onto the advancement such as with Magical Secrets:
Item.Choice.-.Drops.webm
If a choice is available over multiple levels like Metamagic, the previously made choices will be shown:
Item.Choice.-.Previous.Choices.webm
Configuration is handled through an interface similar to Grant Items, but with the level list allowing to specify how many choices are available at which levels:
This also adds the ability to configure spells that are added through Item Grant or Item Choice advancements, setting ability, preparation mode, and limited uses:
Resolves #1401
To Do